search

microsoft / mu_devops

Project Mu Developer Operations
https://microsoft.github.io/mu/
Other
27 stars 25 forks source link

Change NuGetAuthenticate task to version 1. #296

Closed apop5 closed 8 months ago

apop5 commented 9 months ago

Need to switch mu_devops to use NuGetAuthenticate@1 tasks. NuGetAuthenticate@0 is being depreciated, in some pipelines, starting 2024.01.31.

https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/nuget-authenticate-v0?view=azure-pipelines https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/nuget-authenticate-v1?view=azure-pipelines

Fixes #289

apop5 commented 9 months ago

@makubacki

Do you know of a pipeline where Steps/Nuget.yml is being used so I can test this?

makubacki commented 9 months ago

Was there a particular reason to change the YAML formatting? If that's going to be done, it should be in a separate commit from the actual change. However, if that is a direction we'd strongly like to go, it really should be done in a single commit in a separate PR (that can be squashed if needed). Then, the formatting only commit can be removed from git blame.

I don't recall NuGet usage without looking around a bit. In some places, like mu_tiano_platforms, that push to a NuGet feed but I don't recall where the template is used versus inline NuGet code.

apop5 commented 9 months ago

Was there a particular reason to change the YAML formatting? If that's going to be done, it should be in a separate commit from the actual change. However, if that is a direction we'd strongly like to go, it really should be done in a single commit in a separate PR (that can be squashed if needed). Then, the formatting only commit can be removed from git blame.

I don't recall NuGet usage without looking around a bit. In some places, like mu_tiano_platforms, that push to a NuGet feed but I don't recall where the template is used versus inline NuGet code.

The formatting was unintentional, I will revert it.

The other repos using nugetauthenticate, when they were updated, did not need any other change from the @0 to @1, but they were doing their authenticates inline in the projects.