search

microsoft / mu_devops

Project Mu Developer Operations
https://microsoft.github.io/mu/
Other
27 stars 25 forks source link

Add extra_npm_args for InstallMarkdownLink.yml and InstallSpellCheck #361

Closed MarcChen46 closed 2 months ago

MarcChen46 commented 2 months ago

Add "extra_npm_args" for InstallMarkdownLint.yml and InstallSpellCheck.yml steps to increase the flexibility to npm actions.

MarcChen46 commented 2 months ago

@apop5, please help reviewing it, thanks.

apop5 commented 2 months ago

@MarcChen46

What was the reasoning for not using Npm@1

MarcChen46 commented 2 months ago

@MarcChen46

What was the reasoning for not using Npm@1

@apop5, if use the Npm@1, it needs to provide .npmrc to customRegistry, but maybe not all projects has .npmrc in their repo, so I'm thinking for backward compatible reason, I keep the steps the same and use parameter to pass the registry.

apop5 commented 2 months ago

Thanks Marc