search

microsoft / mu_devops

Project Mu Developer Operations
https://microsoft.github.io/mu/
Other
27 stars 25 forks source link

Split approval and merge workflows #76

Closed makubacki closed 1 year ago

makubacki commented 1 year ago

Split approval and merge workflows

Splitting the workflows provides several benefits:

  1. Simplifies logic due to jobs being attached to separate triggers relevant for the specific job.
  2. Reduces number of status checks shown in PRs due to certain steps being skipped in irrelevant circumstances.
  3. Allows better workflow reuse.

The reviewers are also dropped from dependabot PRs since the pending team reviewer is (1) not acted upon (2) can delay PR merging if the reviewer team has not reviewed the PR.

The version is updated in anticipation of this change. It will be modified if the expected version changes before this PR is merged.

Signed-off-by: Michael Kubacki michael.kubacki@microsoft.com

makubacki commented 1 year ago

These are some adjustments I'd like to make after looking at some of the recent bot PRs. I'm planning to keep most of the bot PRs open until this is completed to run them against this set of changes.