microsoft / mu_feature_config

Project Mu - Feature Repo - UEFI User Config and Management Support
https://microsoft.github.io/mu/
Other
20 stars 24 forks source link

[Feature]: Add the include concept into the XML file to increase the reusability #352

Closed MarcChen46 closed 4 months ago

MarcChen46 commented 4 months ago

Feature Overview

In current design, each project needs to create their own XML file as a default golden config, but from project point of view, it is possible that there are multiple config knobs are the same and common across different projects, if we could add the "include" concept in the XML, then it could increase the reusability of the common XML file.

Solution Overview

Alternatives Considered

No response

Urgency

Low

Are you going to implement the feature request?

Someone else needs to implement the feature

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

@ray007330 would study how to implement it and update detail here later.

os-d commented 4 months ago

I believe we can solve the pain point you bring up in a different way that more closely aligns with the goals of mu_feature_config. One large goal of this configuration system is to enable platform owners to create meaningful configuration options that are distinct from the set of silicon/oem/core configuration options. Many platforms carry far too many configuration options that are not meaningful to the platform beyond an initial tuning point. To this end, I think we can enable the tuning case with autogenerated configuration knobs from silicon/oem/core configuration options that should provide a better experience than XML inclusion and then work to have the platform only use these options at a tuning time and trim down the platform options to meaningful user supplied configuration options by shipping time. To that end, I am closing this request, but opening another issue to track the autogen work.