Closed mario-posso-escobar closed 2 months ago
@microsoft-github-policy-service agree company="Microsoft"
Attention: Patch coverage is 1.37931%
with 143 lines
in your changes missing coverage. Please review.
Project coverage is 35.92%. Comparing base (
e21d89d
) to head (2ace030
).:exclamation: Current head 2ace030 differs from pull request most recent head 6278031
Please upload reports for the commit 6278031 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
SetupDataPkg/Tools/KnobService.py | 0.00% | 143 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I guess we need the documentation updated as well to show an example of how to utilize this new functionality.
Preface
Please ensure you have read the contribution docs prior to submitting the pull request. In particular, pull request guidelines.
Description
Add a header reference field to the XML definitions to allow flexible build inclusion patterns.
For each item, place an "x" in between
[
and]
if true. Example:[x]
. (you can also check items in the GitHub UI)How This Was Tested
Tested with locally updated sampleschema.xml. Tested end-to-end with SCP firmware.
Integration Instructions
'headerRef' is an optional attribute that, when used, is consumed by KnobService to reference headers instead of generating the 'Enum' and 'Struct' type definitions in-place. This attribute will not breaking existing XMLs.