microsoft / mu_feature_config

Project Mu - Feature Repo - UEFI User Config and Management Support
https://microsoft.github.io/mu/
Other
20 stars 27 forks source link

Switch to use edk2-pytool-library UefiVariableSupportLib. #362

Closed apop5 closed 3 months ago

apop5 commented 5 months ago

Description

There are multiple copies of VariableSupportLib floating across repos, mostly only supporting Windows. Functionality has been consolidated into edk2-pytool-library version 0.21.7. Support for Linux has been added.

Switch ReadUefiVarsToConfVarList.py, PyRobotRemote.py, WrapAndSetSvd.py and WriteConfVarListToUefiVars.py to use consolidated version from edk2-pytool-library.

Removed local copies of VariableSupportLib.py

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

Integration Instructions

N/A

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 36.24%. Comparing base (7a3ae63) to head (eac7498).

:exclamation: Current head eac7498 differs from pull request most recent head 314c7f7

Please upload reports for the commit 314c7f7 to get more accurate results.

Files Patch % Lines
SetupDataPkg/Tools/WrapAndSetSvd.py 0.00% 2 Missing :warning:
SetupDataPkg/Tools/ReadUefiVarsToConfVarList.py 0.00% 1 Missing :warning:
SetupDataPkg/Tools/WriteConfVarListToUefiVars.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #362 +/- ## ========================================== + Coverage 36.22% 36.24% +0.02% ========================================== Files 31 31 Lines 6258 6254 -4 Branches 449 449 ========================================== Hits 2267 2267 + Misses 3989 3985 -4 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_config/pull/362/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/microsoft/mu_feature_config/pull/362/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `27.58% <0.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.