search

microsoft / mu_feature_config

Project Mu - Feature Repo - UEFI User Config and Management Support
https://microsoft.github.io/mu/
Other
19 stars 24 forks source link

New write_csv_detailed() to dump out data in expanded format #365

Closed nancykhoury closed 1 month ago

nancykhoury commented 3 months ago

Preface

Please ensure you have read the contribution docs prior to submitting the pull request. In particular, pull request guidelines.

Description

<_Please include a description of the change and why this change was made._> For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested <_Please describe the test(s) that were run to verify the changes._> ## Integration Instructions <_Describe how these changes should be integrated. Use N/A if nothing is required._>
codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 3.12500% with 31 lines in your changes missing coverage. Please review.

Project coverage is 36.07%. Comparing base (ae0f15a) to head (dc1b569).

:exclamation: Current head dc1b569 differs from pull request most recent head de7fc0d

Please upload reports for the commit de7fc0d to get more accurate results.

Files Patch % Lines
SetupDataPkg/Tools/VariableList.py 3.12% 31 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #365 +/- ## ========================================== - Coverage 36.24% 36.07% -0.17% ========================================== Files 31 31 Lines 6258 6290 +32 Branches 669 669 ========================================== + Hits 2268 2269 +1 - Misses 3984 4015 +31 Partials 6 6 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_config/pull/365/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/microsoft/mu_feature_config/pull/365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `27.39% <3.12%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nancykhoury commented 3 months ago

@microsoft-github-policy-service agree company="Microsoft"