Closed apop5 closed 3 months ago
@os-d
Can you double check if this is acceptable?
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
main@482fa28
). Learn more about missing BASE report.:exclamation: Current head fcfef99 differs from pull request most recent head 23e1224
Please upload reports for the commit 23e1224 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Commit #369 erroneously removed the implementation for GetConfigKnobOverride from ConfigKnobShimPeiLib. Adding back the implementation to PEI and fixing the unit test to correctly work, in the same fashion as Dxe/MM versions.
For each item, place an "x" in between
[
and]
if true. Example:[x]
. (you can also check items in the GitHub UI)How This Was Tested
Mu Oem sample was failing with an unresolved external GetConfigKnobOverride for X64 PEI. After making this change, the unresolved external was resolved.
Integration Instructions
N/A