microsoft / mu_feature_config

Project Mu - Feature Repo - UEFI User Config and Management Support
https://microsoft.github.io/mu/
Other
19 stars 24 forks source link

SetupDataPkg/ConfigKnobShimPeiLib: Revert ConfigKnobShimPeiLib change and fix unit test. #371

Closed apop5 closed 3 months ago

apop5 commented 3 months ago

Description

Commit #369 erroneously removed the implementation for GetConfigKnobOverride from ConfigKnobShimPeiLib. Adding back the implementation to PEI and fixing the unit test to correctly work, in the same fashion as Dxe/MM versions.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

Mu Oem sample was failing with an unresolved external GetConfigKnobOverride for X64 PEI. After making this change, the unresolved external was resolved.

Integration Instructions

N/A

apop5 commented 3 months ago

@os-d

Can you double check if this is acceptable?

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@482fa28). Learn more about missing BASE report.

:exclamation: Current head fcfef99 differs from pull request most recent head 23e1224

Please upload reports for the commit 23e1224 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #371 +/- ## ======================================= Coverage ? 36.22% ======================================= Files ? 31 Lines ? 6258 Branches ? 449 ======================================= Hits ? 2267 Misses ? 3989 Partials ? 2 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_config/pull/371/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/microsoft/mu_feature_config/pull/371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `27.56% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.