search

microsoft / mu_feature_mm_supv

Project Mu - Feature Repo - MM Supervisor
https://microsoft.github.io/mu
Other
46 stars 28 forks source link

Move secure policy into a common library #277

Closed kuqin12 closed 5 months ago

kuqin12 commented 5 months ago

Preface

Please ensure you have read the contribution docs prior to submitting the pull request. In particular, pull request guidelines.

Description

The preparation and walk through of general policy as well as memory policy are common code that does not require module specific knowledge.

This change moves the policy related manipulation code into a common library implementation.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

This was tested on QEMU Q35 platform and booted to UEFI shell.

Integration Instructions

N/A

github-advanced-security[bot] commented 5 months ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (feature/spam@5725c01). Click here to learn what that means.

Files Patch % Lines
...mSupervisorPkg/Library/SecurePolicyLib/MemPolicy.c 0.00% 24 Missing :warning:
MmSupervisorPkg/Core/MmSupervisorCore.c 0.00% 11 Missing :warning:
...ervisorPkg/Library/SecurePolicyLib/GeneralPolicy.c 0.00% 5 Missing :warning:
MmSupervisorPkg/Core/Request/FetchPolicy.c 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/spam #277 +/- ## ============================================== Coverage ? 0.46% ============================================== Files ? 144 Lines ? 22348 Branches ? 60 ============================================== Hits ? 105 Misses ? 22238 Partials ? 5 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/277/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MmSupervisorPkg](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.46% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.