microsoft / mu_feature_mm_supv

Project Mu - Feature Repo - MM Supervisor
https://microsoft.github.io/mu
Other
48 stars 29 forks source link

Integrate validation routine into SPAM core #278

Closed kuqin12 closed 7 months ago

kuqin12 commented 7 months ago

Preface

Please ensure you have read the contribution docs prior to submitting the pull request. In particular, pull request guidelines.

Description

The current code does not use the validation routine from newly introduced responder code, causing a few misses on the linked symbols and optimized PCDs.

This change will use the routine in SPAM core and thus pulling in a few functional changes in the page table functions.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

This change is tested to be buildable.

Integration Instructions

N/A

kuqin12 commented 7 months ago

Needs https://github.com/microsoft/mu_feature_mm_supv/pull/277 to complete first.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (feature/spam@2794f5d). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/spam #278 +/- ## ============================================== Coverage ? 0.46% ============================================== Files ? 144 Lines ? 22348 Branches ? 60 ============================================== Hits ? 105 Misses ? 22238 Partials ? 5 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/278/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MmSupervisorPkg](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/278/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.46% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.