microsoft / mu_feature_mm_supv

Project Mu - Feature Repo - MM Supervisor
https://microsoft.github.io/mu
Other
48 stars 29 forks source link

Fix Dsc offsets in MmiEntrySpam.nasmb #284

Closed kenlautner closed 6 months ago

kenlautner commented 6 months ago

Description

The values used for the various DSC offsets in MmiEntrySpam.nasmb were based on the normal SmiEntry.nasm used in the MM Supervisor. Instead, the needed to align with the STM file structure. This change changes the offsets to correctly match the structure they're referencing when pulling variable data.

Additionally, SmmStm.c was updated to reference mXdSupported instead of gPatchDxSupported. This also included a check for setting gPatchMsrIa32MiscEnableSupported based on the return value of StandardSignatureIsAuthenticAMD().

Also 2 files in the spam core had uncrustified run on them to pass CI.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

Tested on Intel physical platform. The correct offsets are being used to get the relevant CS/DS/SS values.

Integration Instructions

N/A

kuqin12 commented 6 months ago

Please wait till the pipeline got through before merging.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (feature/spam@545e34b). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/spam #284 +/- ## ============================================== Coverage ? 0.46% ============================================== Files ? 144 Lines ? 22348 Branches ? 60 ============================================== Hits ? 105 Misses ? 22238 Partials ? 5 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/284/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MmSupervisorPkg](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/284/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.46% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.