microsoft / mu_feature_mm_supv

Project Mu - Feature Repo - MM Supervisor
https://microsoft.github.io/mu
Other
48 stars 29 forks source link

Restructure the validation routine and its dependent functions #288

Closed kuqin12 closed 6 months ago

kuqin12 commented 6 months ago

Preface

Please ensure you have read the contribution docs prior to submitting the pull request. In particular, pull request guidelines.

Description

This change removed some redundant code in the validation routine, updated the measurement function interface to return the digest list from measurement operations.

Lastly, the TPM measurement PCR is changed to a fixed at build PCD and default to 17, which will pave way to normal UEFI testing in the upcoming work.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

This was tested on QEMU Q35 and verified bootable to UEFI shell.

Integration Instructions

N/A

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (feature/spam@faa8e74). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/spam #288 +/- ## ============================================== Coverage ? 0.46% ============================================== Files ? 144 Lines ? 22349 Branches ? 60 ============================================== Hits ? 105 Misses ? 22239 Partials ? 5 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/288/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MmSupervisorPkg](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/288/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.46% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.