microsoft / mu_feature_mm_supv

Project Mu - Feature Repo - MM Supervisor
https://microsoft.github.io/mu
Other
46 stars 28 forks source link

Remove PCR extension from the validation routine #296

Closed kuqin12 closed 4 months ago

kuqin12 commented 4 months ago

Preface

Please ensure you have read the contribution docs prior to submitting the pull request. In particular, pull request guidelines.

Description

This change will remove the PCR extension step from the validation routine as this will not be picked up by OS anyhow.

However, the routine will keep the hashing functionality on the TPM side to avoid including cryptographic functionality in the SPAM core.

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

This was tested on QEMU Q35 and given test application.

Integration Instructions

N/A

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feature/spam@8e530fa). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/spam #296 +/- ## ============================================== Coverage ? 0.46% ============================================== Files ? 144 Lines ? 22349 Branches ? 60 ============================================== Hits ? 105 Misses ? 22239 Partials ? 5 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/296/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MmSupervisorPkg](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/296/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.46% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.