microsoft / mu_feature_mm_supv

Project Mu - Feature Repo - MM Supervisor
https://microsoft.github.io/mu
Other
46 stars 28 forks source link

Fixing override break due to PiSmmCpuDxeSmm updates #304

Closed kuqin12 closed 3 months ago

kuqin12 commented 3 months ago

Preface

Please ensure you have read the contribution docs prior to submitting the pull request. In particular, pull request guidelines.

Description

This change is integrating the changes from BASECORE: https://github.com/microsoft/mu_basecore/commit/ff7dabfdca8534a1d1b3551e91b739be20a5f8fc https://github.com/microsoft/mu_basecore/commit/719bf756ea6d94ef800eaab4601d3ed52423ef35

For each item, place an "x" in between [ and ] if true. Example: [x]. (you can also check items in the GitHub UI)

How This Was Tested

This change is tested with QEMU Q35.

Integration Instructions

This requires the platforms to update their BASECORE version to be later than https://github.com/microsoft/mu_basecore/commit/719bf756ea6d94ef800eaab4601d3ed52423ef35 of release/202311.

apop5 commented 3 months ago

If this is a breaking change, can you describe the changes necessary in the integration instructions?

kuqin12 commented 3 months ago

If this is a breaking change, can you describe the changes necessary in the integration instructions?

Thanks. It is basically saying that one needs to update basecore to latest. I will add that in the integration instruction section.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 0.47%. Comparing base (e81d8e4) to head (8a39fa9). Report is 1 commits behind head on main.

Files Patch % Lines
MmSupervisorPkg/Core/Relocate/Relocate.c 0.00% 20 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #304 +/- ## ======================================== - Coverage 0.47% 0.47% -0.01% ======================================== Files 144 144 Lines 22066 22079 +13 Branches 60 60 ======================================== Hits 105 105 - Misses 21956 21969 +13 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/304/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MmSupervisorPkg](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/304/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.47% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.