Closed kenlautner closed 3 months ago
Attention: Patch coverage is 0%
with 43 lines
in your changes missing coverage. Please review.
Project coverage is 0.47%. Comparing base (
1619bce
) to head (06fbd63
).
Files | Patch % | Lines |
---|---|---|
MmSupervisorPkg/Core/Mem/SmmCpuMemoryManagement.c | 0.00% | 42 Missing :warning: |
MmSupervisorPkg/Core/Mem/PageTbl.c | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Updated AllocatePageTableMemory to include a new input variable *NewAllocation. This variable is used to keep track of if new pages were allocated for use in the page table page pool. This fixes a bug where if we run out of page table pool pages while changing some pages memory attributes we'll recursively call into ConvertMemoryPageAttributes while allocating pages leading to unaccounted for pages in the original call. This leads to an assert by the ConvertMemoryPageAttributes code.
How This Was Tested
Tested on two separate physical platforms that experienced the issue in different circumstances. This fix tested on those reproing platforms have the issue resolved and no longer saw any asserts.
Integration Instructions
N/A