microsoft / mu_feature_mm_supv

Project Mu - Feature Repo - MM Supervisor
https://microsoft.github.io/mu
Other
46 stars 28 forks source link

Fixing MmRanges would pull in extra data from the next hob #337

Closed kuqin12 closed 1 week ago

kuqin12 commented 1 week ago

Description

Currently the MmRanges reported through initialization steps will be manipulated by the IPL code to extend the last entry to be an empty placeholder so that it will be populated during the ExecuteMmCoreFromMmram routine.

However, the preemptively extended range will pull in extra data from the next hob, which could cause the rest of supervisor initialization to fault. This change fixed such issue by not overly copying data from hob.

For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.

How This Was Tested

This was tested on both QEMU Q35 and proprietary hardware platforms.

Integration Instructions

N/A

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.50%. Comparing base (d8aa426) to head (26c41cf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #337 +/- ## ===================================== Coverage 0.50% 0.50% ===================================== Files 143 143 Lines 20942 20942 Branches 60 60 ===================================== Hits 105 105 Misses 20832 20832 Partials 5 5 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/337/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MmSupervisorPkg](https://app.codecov.io/gh/microsoft/mu_feature_mm_supv/pull/337/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `0.50% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.