codecov-commenter
commented
1 month ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 10.65%. Comparing base (
5d44a00) to head (5f94a11). Report is 1 commits behind head on release/202311.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## release/202311 #540 +/- ## ================================================== - Coverage 11.01% 10.65% -0.36% ================================================== Files 144 144 Lines 22079 22013 -66 Branches 2356 2356 ================================================== - Hits 2432 2346 -86 + Misses 19615 19579 -36 - Partials 32 88 +56 ``` | [Flag](https://app.codecov.io/gh/microsoft/mu_plus/pull/540/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [AdvLoggerPkg](https://app.codecov.io/gh/microsoft/mu_plus/pull/540/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `3.60% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
The PCD PcdAdvancedLoggerPeiInRam does not work and is being removed. For Intel systems, the PEI phase uses cache-as-ram and determines that there is no way to allocate memory. This PCD was supposed to signal to the logger that it could allocate memory, however, it would error as memory allocation was not allowed in that phase.
How This Was Tested
Ran the CI build for all packages in mu_plus for the X64 architecture. All tests passing.
Integration Instructions
Users of PcdAdvancedLoggerPeiInRam will need to remove that PCD from DSCs. It is not expected there are users as the PCD does not work, although platforms may have specifically set it to FALSE.