search

microsoft / mup

maximal update parametrization (µP)
https://arxiv.org/abs/2203.03466
MIT License
1.25k stars 90 forks source link

missing os import in mup/examples/MLP/main.py ? #19

Closed james-simon closed 1 year ago

james-simon commented 2 years ago

Just thought I'd let you know that, when I ran python mup/examples/MLP/main.py --load_base_shapes ./mup/examples/MLP/width64.bsh, I got an error at the very bottom (when saving the .tsv) because os wasn't imported (losing a few hours of runtime!). Adding import os to the header fixed that. Maybe I was doing something wrong, but thought I'd flag it just in case

edwardjhu commented 2 years ago

This looks like an oversight on our end. Thanks for flagging!!