Proper error return in coord_check.py

microsoft / mup

maximal update parametrization (µP)

https://arxiv.org/abs/2203.03466

MIT License

1.24k stars 88 forks source link

Closed TevenLeScao closed 1 year ago

TevenLeScao commented 1 year ago

Super small bug fix - NotImplementedError is what you want to properly raise this error and give the type to the user

TevenLeScao commented 1 year ago

(currently it just says "NotImplemented is not callable" which is misleading and also doesn't allow to see the offending type in the error)