search

microsoft / mwt-ds

Umbrella repository for projects related to the MWT Decision Service
187 stars 77 forks source link

Accept namespaces, learning rate range, regularization range, as input; started work towards automating latter two #116

Closed sidsen closed 6 years ago

marco-rossi29 commented 6 years ago

Commit 1096e39 is already in master from pull request 112

marco-rossi29 commented 6 years ago

@sidsen Do you want me to review this pull request or are you still working on it?

sidsen commented 6 years ago

This is ready to be merged. I will continue working on automation but this is an intermediate step that works.

Sid

On Nov 30, 2017 10:54 PM, "Marco Rossi" notifications@github.com wrote:

@sidsen https://github.com/sidsen Do you want to merge this pull request or are you still working on it?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microsoft/mwt-ds/pull/116#issuecomment-348416522, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPASsccO5JZy2Q6lUKDvImc10XMN0CTks5s76KEgaJpZM4QvHov .

sidsen commented 6 years ago

Sorry, it seems I had changes but didn't update the pull request. I backed them out in favor of yours. Numpy is causing problems in some installations I have -- do you think we should just treat that as a built-in package that everyone will have, or should we avoid depending on it if we don't really need it?