Experimentation.py improvements

microsoft / mwt-ds

Umbrella repository for projects related to the MWT Decision Service

187 stars 77 forks source link

Experimentation.py improvements #120

Closed marco-rossi29 closed 6 years ago

marco-rossi29 commented 6 years ago

Refactored Command class
Fixed bug in marginals
Added regularization and power_t to initial (and final) sweep
Stop greedy quadratic addition if no improvement after N rounds
Using locals() to create variables from CLI
Cosmetic changes

sidsen commented 6 years ago

Did we figure out a way to add me as a reviewer?

marco-rossi29 commented 6 years ago

@sidsen No. @eisber has to add you as a memebr of mwt-ds (right now you are a contributor). BTW, do you like this pull request? I took your commit and refactored Command. What's still lest out is the ./vw which in my platform doesn't work

marco-rossi29 commented 6 years ago

Me and @sidsen reviewed this pull request and made few changes.