microsoft / mwt-ds

Umbrella repository for projects related to the MWT Decision Service
187 stars 77 forks source link

Custom policy evaluation should pass in --dsjson parameter to vw #147

Closed sharathmalladi closed 4 years ago

sharathmalladi commented 5 years ago

Currently, if the input custom policy does not have --dsjson in the policy arguments, the custom policy is failing. We need to ensure vw is called with --dsjson.

sharathmalladi commented 5 years ago

More context: The code that creates a vw command: https://github.com/microsoft/mwt-ds/blob/master/DataScience/ExperimentationAzure.py#L114 currently fails if the input custom_command does not have "--djson" in it. We should not expect "--dsjson" since that is not part of machine learning policy. Instead, we should change the code to add that argument prior to calling vw.