Closed limotley closed 4 years ago
sys.exit()
sys.exit(1) here? #Closed
Refers to: DataScience/LogDownloader.py:15 in 5d61327. [](commit_id = 5d6132791c0ec9dcae0cd80e4d4d5427e1c1798e, deletion_comment = False)
import dashboard_utils
I see at least one line in dashboard_utils .. where we have this line: Error: Prediction file length ({}) must be equal for all files
Could you please scrub that file to for places where we need to exit with an error. #Closed
Refers to: DataScience/ExperimentationAzure.py:7 in 5d61327. [](commit_id = 5d6132791c0ec9dcae0cd80e4d4d5427e1c1798e, deletion_comment = False)
azure_util.upload_to_blob(ld_args.app_id, os.path.join(main_args.output_folder, "experiments.csv"), experiments_file_path)
Add an extra argument for throw_ex and set to True. #Closed
Refers to: DataScience/ExperimentationAzure.py:135 in 5d61327. [](commit_id = 5d6132791c0ec9dcae0cd80e4d4d5427e1c1798e, deletion_comment = False)
azure_util.upload_to_blob(ld_args.app_id, os.path.join(main_args.output_folder, "experiments.csv"), experiments_file_path)
I actually prefer making throw_ex a constructor argument to AzureUtil and set it to True. So we don't have to pass this flag to every api call.
In reply to: 635759240 [](ancestors = 635759240)
Refers to: DataScience/ExperimentationAzure.py:135 in 5d61327. [](commit_id = 5d6132791c0ec9dcae0cd80e4d4d5427e1c1798e, deletion_comment = False)
Should we exit after this? If the download failed, then further steps are not relevant. #Closed
Refers to: DataScience/LogDownloader.py:132 in 5d61327. [](commit_id = 5d6132791c0ec9dcae0cd80e4d4d5427e1c1798e, deletion_comment = False)