search

microsoft / mwt-ds

Umbrella repository for projects related to the MWT Decision Service
187 stars 77 forks source link

GenericTopSlotExplorer ExplorerDecision Exception #52

Open HappyCoderMan opened 8 years ago

HappyCoderMan commented 8 years ago

I have an app that uses decisionService.ChooseRanking with 81 actions, and theGenericTopSlotExplorer ExplorerDecision threw its "Probabilities must sum to one." exception as shown in this screenshot.

I put a red box around the "total -1f" in the watch window, which is the condition checked before the exception is thrown.

image

JohnLangford commented 8 years ago

This looks like a precision issue to me since floats work to 1e-6 precision. Maybe we should upgrade the probabilities to doubles? Either that or use a less stringent test.

-John

On Sat, Jul 16, 2016 at 3:12 PM, ErikOmberg notifications@github.com wrote:

I have an app that uses decisionService.ChooseRanking with 81 actions, and theGenericTopSlotExplorer ExplorerDecision threw its "Probabilities must sum to one." exception as shown in this screenshot.

I put a red box around the "total -1f" in the watch window, which is the condition checked before the exception is thrown.

[image: image] https://cloud.githubusercontent.com/assets/8632110/16896664/452da758-4b5f-11e6-84d0-e6538783ded0.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Microsoft/mwt-ds/issues/52, or mute the thread https://github.com/notifications/unsubscribe-auth/AAE25jopU5PNSVVRrFOyZXGr61C4N0N5ks5qWS07gaJpZM4JOE2y .

eisber commented 8 years ago

@JohnLangford: change to 1e-3?

eisber commented 8 years ago

We’ll change to 1e-4.

Markus