microsoft / mwt-ds

Umbrella repository for projects related to the MWT Decision Service
187 stars 77 forks source link

Properly log scoring model Id #78

Closed lhoang29 closed 8 years ago

lhoang29 commented 8 years ago

Fixed 2 issues:

  1. Client library was logging inconsistent JSON structure for the mapper state.
  2. ASA join query was dropping model Ids.

@eisber how do I get ASA to ignore writing out NULL values? e.g. "_model_id": null should be excluded

eisber commented 8 years ago

I don’t think you can. Once an event contained that field I believe the schema is growing and they’ll start outputting null values. Big issue?

From: Luong Hoang [mailto:notifications@github.com] Sent: Wednesday, September 14, 2016 11:51 PM To: Microsoft/mwt-ds mwt-ds@noreply.github.com Cc: Markus Cozowicz marcozo@microsoft.com; Mention mention@noreply.github.com Subject: [Microsoft/mwt-ds] Properly log scoring model Id (#78)

Fixed 2 issues:

  1. Client library was logging inconsistent JSON structure for the mapper state.
  2. ASA join query was dropping model Ids.

@eisberhttps://github.com/eisber how do I get ASA to ignore writing out NULL values? e.g. "_model_id": null should be excluded


You can view, comment on, or merge this pull request online at:

https://github.com/Microsoft/mwt-ds/pull/78

Commit Summary

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/mwt-ds/pull/78, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJrCThXGa0Nx_D_GyGHuwJMgziopE2Jdks5qqMC-gaJpZM4J9eR9.

lhoang29 commented 8 years ago

no, just trying to optimize

lhoang29 commented 8 years ago

E2E test passed