search

microsoft / mwt-ds

Umbrella repository for projects related to the MWT Decision Service
187 stars 77 forks source link

Local mode version of the Decision Service #83

Closed sidsen closed 7 years ago

sidsen commented 7 years ago

This pull request contains three separate files needed to implement a local version of the Decision Service. The only change to the main client library code was to unseal the DecisionServiceClient class. A better architecture might be to create a common base class and have one subclass be the local version and another be the remote (join service uploading) version, but this seems like a reasonable change for now. The other files involved are an in-memory logger implementation and some testing code. There may also be an assembly directive to allow the ClientDecisionServiceTest project to access the ClientDecisionService internals.

sidsen commented 7 years ago

I believe all the comments should be addressed by now. I will track the use of this code (especially for systems infrastructure apps) and revisit the hierarchical design in the future.

sidsen commented 7 years ago

Didn't see the last round of comments, fixing them now.

sidsen commented 7 years ago

I think most of the concerns have been addressed, with one or two items deferred to the future in case this sees more use. Let me know if there's anything to do on my end, or if you are comfortable accepting the PR. Thanks!