search

microsoft / mwt-ds

Umbrella repository for projects related to the MWT Decision Service
187 stars 77 forks source link

Fixing issue with Date Range #91

Closed abgoswam closed 7 years ago

abgoswam commented 7 years ago

This PR addresses issues related to mismatch of data range.

With this fix, we now see missing events 0 for an example run with TR dataset where previously we were seeing ~1K missing events

eisber commented 7 years ago

thanks! can you address the comments?

eisber commented 7 years ago

The additional amount of events we have to load depends on the experimental unit duration. For Track Revenue it’s 20h (or so).

Maybe experimental_unit_duration = 1 An interpret the number as days?

eisber commented 7 years ago

Oh, then just remove.