search

microsoft / navcontainerhelper

Official Microsoft repository for BcContainerHelper, a PowerShell module, which makes it easier to work with Business Central Containers on Docker.
MIT License
379 stars 243 forks source link

Get-BestBcContainerImageName returns image name without ltsc2019 #1101

Closed ernestasjuska closed 4 years ago

ernestasjuska commented 4 years ago

Describe the issue 2004 is both tag for BC version (2020 Wave I) and Windows build 2004. Because of that cmdlet does not append ltsc2019 when it should. See first if in https://github.com/microsoft/navcontainerhelper/blob/master/ContainerHandling/Get-BestNavContainerImageName.ps1.

Example

Get-BestBcContainerImageName -imageName mcr.microsoft.com/businesscentral/onprem:2004 returns mcr.microsoft.com/businesscentral/onprem:2004, but Get-BestBcContainerImageName -imageName mcr.microsoft.com/businesscentral/onprem:1910 returns mcr.microsoft.com/businesscentral/onprem:1910-ltsc2019.

Additional context

navcontainerhelper v0.7.0.13

image

ernestasjuska commented 4 years ago

For now adding ltsc2019 manually. I only needed that our in devops pipeline where we manually pull image (with some timeout for ALOps).

freddydk commented 4 years ago

Thanks. As you might have seen on my blog (http://www.freddysblog.com) we are changing from images to artifacts. This means that soon we will stop building images altogether and eventually we will delete the existing images. I know ALOps has support for artifacts already, you should switch.

ernestasjuska commented 4 years ago

Thanks. Will checkout ALOps.