search

microsoft / node-native-keymap

Provide OS keyboard layout functionality as a nodejs module
MIT License
136 stars 37 forks source link

Support for FreeBSD #3

Closed WouterDemuynck closed 8 years ago

WouterDemuynck commented 8 years ago

Hey,

I was working on my FreeBSD system and stumbled across an issue building this package. Basically, I've changed the binding.gyp file to properly link against X11 on FreeBSD as well as one source code issue where there was a collision with a globally defined variable in the C++ library.

Kind regards,

Wouter

msftclas commented 8 years ago

Hi @WouterDemuynck, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

alexdima commented 8 years ago

@WouterDemuynck Thank you, looks brilliant! Can I please ask you to sign the contribution license agreement so I can merge this in? https://cla.microsoft.com

WouterDemuynck commented 8 years ago

Certainly, I've just signed it and got the completion e-mail from DocuSign. Do I need to e-mail the PDF to someone?

alexdima commented 8 years ago

@WouterDemuynck Thanks! Usually, the robot picks that up immediately and adds a cla-signed tag. I will follow up with the folks that manage this integration and see what's wrong ... Maybe I've set up this repository incorrectly. e.g. where it works https://github.com/Microsoft/vscode/pulls

msftclas commented 8 years ago

Hi @WouterDemuynck, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

alexdima commented 8 years ago

Closed and reopened to get the robot to wake up :).

alexdima commented 8 years ago

Thank you very much again! :heart:

WouterDemuynck commented 8 years ago

No problem, happy coding! ;)