microsoft / node-native-keymap

Provide OS keyboard layout functionality as a nodejs module
MIT License
136 stars 37 forks source link

Support Electron 32 #60

Open johnlindquist opened 1 month ago

johnlindquist commented 1 month ago

I'm getting the same error for node-native-keymap as the sqlite package was getting when attempting upgrade to Electron 32:

/Users/johnlindquist/.electron-gyp/32.0.1/include/node/v8config.h:13:2: error: "C++20 or later required."

https://github.com/WiseLibs/better-sqlite3/pull/1226

I tried forking and solving it myself, but it's just too far out of my wheelhouse to fully understand the problem. Please help :)

Maybe it's related to this?

https://github.com/electron/rebuild/issues/1044

asamofal commented 1 month ago

Double check that you use v11.2.1 that includes #1226.

v11.2.1 works fine for me now.

johnlindquist commented 1 month ago

@asamofal yeah, I was implying it's been fixed in SQLite and that this repo might benefit from a similar fix

asamofal commented 1 month ago

@johnlindquist oh, sorry,I just got the repo confused 🤦‍♂️