search

microsoft / node-pty

Fork pseudoterminals in Node.JS
Other
1.48k stars 242 forks source link

Crashes with Electron 12 #450

Closed Eugeny closed 3 years ago

Eugeny commented 3 years ago

Not sure if I should be filing this here or with Electron.

Repro: require('node-pty').spawn('/bin/sh')

Crash:

Crashed Thread:        0  CrRendererMain  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       EXC_I386_GPFLT
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [67441]

Thread 0 Crashed:: CrRendererMain  Dispatch queue: com.apple.main-thread
0   com.github.Electron.framework   0x000000010944be69 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 65961
1   com.github.Electron.framework   0x0000000109443e8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
2   com.github.Electron.framework   0x0000000109440f1a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 21082
3   com.github.Electron.framework   0x0000000109532ebf v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 1012223
4   com.github.Electron.framework   0x0000000109443e8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
5   com.github.Electron.framework   0x0000000109443e8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33231
6   com.github.Electron.framework   0x0000000109441afb v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 24123
7   com.github.Electron.framework   0x00000001094418d8 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 23576
8   com.github.Electron.framework   0x0000000108f0dc57 v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 3031
9   com.github.Electron.framework   0x0000000108f0d11a v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 154
10  com.github.Electron.framework   0x0000000108ef691f v8::internal::DateCache::ProbeDST(int) + 1711
11  com.github.Electron.framework   0x0000000108e9d71e v8::debug::EvaluateGlobal(v8::Isolate*, v8::Local<v8::String>, v8::debug::EvaluateGlobalMode, bool) + 270
12  com.github.Electron.framework   0x0000000109235869 v8_inspector::V8InspectorSession::canDispatchMethod(v8_inspector::StringView) + 8137
13  com.github.Electron.framework   0x000000010921eb4b v8::sampler::Sampler::Sampler(v8::Isolate*) + 18603
14  com.github.Electron.framework   0x000000010924756e v8_inspector::V8StackTraceId::V8StackTraceId(unsigned long, std::__1::pair<long long, long long>, bool) + 67086
15  com.github.Electron.framework   0x0000000109234c17 v8_inspector::V8InspectorSession::canDispatchMethod(v8_inspector::StringView) + 4983
16  com.github.Electron.framework   0x000000010aa006fd v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 22825533
17  com.github.Electron.framework   0x0000000108e5ba82 electron::fuses::IsRunAsNodeEnabled() + 4940418
18  com.github.Electron.framework   0x0000000109bd40aa v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 7963626
19  com.github.Electron.framework   0x0000000109d0fb8c v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 9256652
20  com.github.Electron.framework   0x0000000109d0e83f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 9251711
21  com.github.Electron.framework   0x0000000109a42b99 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6319833
22  com.github.Electron.framework   0x0000000109a5209f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6382559
23  com.github.Electron.framework   0x0000000109a51d5b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6381723
24  com.github.Electron.framework   0x0000000109a85ad0 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6594064
25  com.github.Electron.framework   0x0000000109a8263a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6580602
26  com.github.Electron.framework   0x0000000109a854af v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6592495
27  com.apple.CoreFoundation        0x00007fff2045da0c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
28  com.apple.CoreFoundation        0x00007fff2045d974 __CFRunLoopDoSource0 + 180
29  com.apple.CoreFoundation        0x00007fff2045d6ef __CFRunLoopDoSources0 + 248
30  com.apple.CoreFoundation        0x00007fff2045c121 __CFRunLoopRun + 890
31  com.apple.CoreFoundation        0x00007fff2045b6ce CFRunLoopRunSpecific + 563
32  com.apple.Foundation            0x00007fff211e8fa1 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 212
33  com.github.Electron.framework   0x0000000109a85f99 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6595289
34  com.github.Electron.framework   0x0000000109a8502b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6591339
35  com.github.Electron.framework   0x0000000109a52cd7 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6385687
36  com.github.Electron.framework   0x0000000109a2f249 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 6239625
37  com.github.Electron.framework   0x000000010b3be728 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) + 33041000
38  com.github.Electron.framework   0x0000000108e3d6fa electron::fuses::IsRunAsNodeEnabled() + 4816634
39  com.github.Electron.framework   0x0000000108e3c2b0 electron::fuses::IsRunAsNodeEnabled() + 4811440
40  com.github.Electron.framework   0x0000000108e3c772 electron::fuses::IsRunAsNodeEnabled() + 4812658
41  com.github.Electron.framework   0x00000001087f0358 ElectronMain + 136
42  com.github.Electron.helper      0x00000001087916e0 0x10878d000 + 18144
43  libdyld.dylib                   0x00007fff20380621 start + 1
Tyriar commented 3 years ago

@deepak1556 I see VS Code is on 11, we may run into problems with this soon?

Eugeny commented 3 years ago

This has been fixed on the Electron side.