search

microsoft / node-pty

Fork pseudoterminals in Node.JS
Other
1.46k stars 236 forks source link

Expose an API to set the path to the worker when used inside ASAR #465

Closed Tyriar closed 2 years ago

Tyriar commented 3 years ago

Packaging node-pty with ASAR doesn't play nice with Worker, it looks like this can be worked around by provided a direct path to where the unpacked worker lives

Tyriar commented 2 years ago

We handle this in VS Code now, can see how we do it in https://github.com/microsoft/vscode/pull/123782 & https://github.com/microsoft/node-pty/blob/6cf84b7e572f2032febb5d8cec469e2f320632e0/src/windowsConoutConnection.ts#L42-L53