search

microsoft / node-pty

Fork pseudoterminals in Node.JS
Other
1.43k stars 232 forks source link

add cf and spectre flags #533

Closed TylerLeonhardt closed 2 years ago

Tyriar commented 2 years ago

What's up with this change? We are currently not on the latest version of node-pty due to not resolving issues that arose in vscode when updating to https://github.com/microsoft/node-pty/pull/487

deepak1556 commented 2 years ago

@Tyriar these are part of the fixes to resolve the issues reported by the BinSkim tool

deepak1556 commented 2 years ago

Module tests does not pass with windows-2022 agent https://github.com/microsoft/node-pty/runs/5583465216, this needs further investigation for future agent updates. Reverted to windows-2019 agent.

TylerLeonhardt commented 2 years ago

@deepak1556 think this is good to go and we'll update the agent later?

deepak1556 commented 2 years ago

Sorry, yeah this PR is good to go, don't have plans to look into the windows-2022 agent failure for now since vscode core still uses 2019 agent. Happy if others want to tackle it now.