fix: enable and fix typecast warnings

microsoft / node-pty

Fork pseudoterminals in Node.JS

Other

1.47k stars 239 forks source link

fix: enable and fix typecast warnings #584

Closed rzhao271 closed 1 year ago

rzhao271 commented 1 year ago

I'd also like to adjust PtyStartProcess to not use goto. There's currently some ugly code workarounds to avoid some compile-time errors due to it.

rzhao271 commented 1 year ago

PR not ready to merge. The kill unit test is flaky. Edit: It looks like the test times out sometimes. Locally it doesn't work due to an EPIPE error. I'd like to investigate in a future PR considering how it could be my setup. I also noticed that adding logging to some unit tests locally often resulted in other unit tests failing due to EPIPE errors.