microsoft / node-pty

Fork pseudoterminals in Node.JS
Other
1.42k stars 233 forks source link

Is there a specific reason for not using `forkpty` on macOS? #590

Closed tamuratak closed 1 year ago

tamuratak commented 1 year ago

Hi,

With #587, forkpty is not used on macOS, used only on Linux. It would increase the maintenance burden. forkpty is also available on macOS.

It seems to work just by removing lines in pty.cc for macOS. The following branch passes tests on macOS.

ProductName: macOS ProductVersion: 11.7.5 BuildVersion: 20G1225

$ node -v v16.19.1

tamuratak commented 1 year ago

476