search

microsoft / node-pty

Fork pseudoterminals in Node.JS
Other
1.42k stars 233 forks source link

Compiler warning about destructor #607

Closed rzhao271 closed 1 year ago

rzhao271 commented 1 year ago

Environment details

Issue description

  1. Run yarn
  2. See the following warning:
<some-path>\node-pty\deps\winpty\src\agent\Agent.cc(231): warning C4722: 'Age
nt::~Agent': destructor never returns, potential memory leak [C:\Users\raymondzhao\work\native-modules\nod 
e-pty\build\deps\winpty\src\winpty-agent.vcxproj]
Tyriar commented 1 year ago

I personally wouldn't touch the winpty codebase unless there's an important security issue. It's legacy and is typically not used/discouraged on modern Windows 11.

rzhao271 commented 1 year ago

Closing for now