chore: remove deprecated api `process.binding`

microsoft / node-pty

Fork pseudoterminals in Node.JS

Other

1.47k stars 239 forks source link

chore: remove deprecated api `process.binding` #653

Closed kkocdko closed 6 months ago

kkocdko commented 9 months ago

This code from pty.js (chjj) was originally designed to work with ancient versions of node.js 0.12 and io.js, but the api is DEPRECATED for many years, the /* require("node:tty") */ tty.ReadStream consturctor received a pipe fd is just worked (both r/w).

Related to #632 .

See https://github.com/nodejs/node/issues/37780 also.

kkocdko commented 9 months ago

GitHub Actions here, combine with #644 .

https://github.com/kkocdko/utils4linux/blob/0cf07f6d541de30667180c29ea876d9df9bf1fdc/.github/workflows/nodepty.yml#L50-L56

deepak1556 commented 6 months ago

Can you rebase on latest main