search

microsoft / node-pty

Fork pseudoterminals in Node.JS
Other
1.47k stars 239 forks source link

Problem with binding.gyp file #665

Closed legendSabbir closed 7 months ago

legendSabbir commented 7 months ago

Environment details

Error while installing . Tried in many devices still same issue . Before it used to work . Stopped working recently .

gyp: Undefined variable android_ndk_path in binding.gyp while trying to load binding.gyp

IMG_20240224_191405_777

bajrangCoder commented 7 months ago

Yes, facing same issue. And this issue started after recent node update (and also maybe due to node-gyp@10 version)

Tried some solution from internet but that doesn't work.

Tyriar commented 7 months ago

You're trying to install on Android? I wasn't aware this ever worked

bajrangCoder commented 7 months ago

You're trying to install on Android? I wasn't aware this ever worked

Previously it used to work. Problem is it needs a "android_ndk_path" variable, but internally there is no need of this, if we will pass an empty android_ndk_path, but explicitly in node-gyp configure.js

Check out this 👉 https://github.com/termux/termux-packages/issues/20717

deepak1556 commented 7 months ago

We are not configuring the mentioned variable in our binding.gyp, please confirm where the variable is being injected from and try to address it there.