fix: upgrade node-gyp to fix macOS build error

microsoft / node-pty

Fork pseudoterminals in Node.JS

Other

1.42k stars 233 forks source link

fix: upgrade node-gyp to fix macOS build error #673

Closed kkocdko closed 3 months ago

kkocdko commented 3 months ago

Fix #643

Fix #646

kkocdko commented 3 months ago

@deepak1556 Hi, could you please take the time to merge this, it would be very useful for macOS (and other environment with Python 3.12) users.

And I think #653 is ready to merge also, we already drop ancient io.js supports. Thank you very much!

kkocdko commented 3 months ago

Not sure why CI APIScan failed .

deepak1556 commented 3 months ago

@sbatten @rzhao271 there is an auth issue with APIScan run, can this be ignored for now ?

ERROR: System.AggregateException: One or more errors occurred. ---> System.TypeInitializationException: The type initializer for 'Microsoft.Tools.ApiScan.ApiScanLib.DataStore.SqlAuthProvider' threw an exception. ---> System.ArgumentException: Connection string $(apiscan-connectionstring) is not in a proper format. Expected format is Key1=Value1;Key2=Value2;

rzhao271 commented 3 months ago

The APIScan issue is unrelated. Merging the PR.

deepak1556 commented 3 months ago

@rzhao271 is the APIScan auth issue tracked somewhere ?