Update to support nan 2.*

microsoft / node-uwp

Enables Universal Windows Platform (UWP) API access for Node.js (Chakra build) on Windows 10.

MIT License

152 stars 26 forks source link

Closed munyirik closed 8 years ago

munyirik commented 8 years ago

Building will still fail until v8.h (chakra) has FunctionTemplate methods SetCallHander and SetCallAsFunctionHandler.

munyirik commented 8 years ago

cc @jianchun

jianchun commented 8 years ago

LGTM.

@kunalspathak Kunal, could you please CR this and follow up?

kunalspathak commented 8 years ago

LGTM. Yes, I will address the issue in node-msft