search

microsoft / nodejstools

Node.js Tools for Visual Studio
http://aka.ms/explorentvs
Apache License 2.0
1.79k stars 359 forks source link

fix angular test discovery #2467

Closed PranavSenthilnathan closed 1 year ago

PranavSenthilnathan commented 1 year ago

The test settings previously always used IPv4 for the listening endpoint. This meant in Node 17+ the tests would not run since node would probe with IPv6. This PR changes it to use localhost which makes the test use the same address that node would use. I tested this change with Node 16 and Node 18 and they both work. Since the change is only to the default values, the user can pass their own values and they will take precedence.

armanio123 commented 1 year ago

Adding link for documentation: https://github.com/karma-runner/karma/issues/3730