microsoft / o365-moodle

Office 365 and Azure Active Directory plugins for Moodle
GNU General Public License v3.0
180 stars 136 forks source link

Could not check reply url #1092

Closed Richardvi closed 4 years ago

Richardvi commented 5 years ago

This bug seems to be back:

sharedscreenshot

Using Moodle 3.5 and latest plugin version 3.5.0.0 (2018051700)

vinnystocker commented 5 years ago

I also have this on my site. As far as I can see everything is set up properly

gd5t commented 5 years ago

Same here. Also, Cron won't run using crontab anymore, stops at first step (local_o365\task\refreshsystemrefreshtoken), but runs manually.

MH-ES commented 5 years ago

Same issue on Moodle 3.5.4+ / Plugin 3.5.0.2

jamesmcq commented 5 years ago

Hi all - this can happen from time to time, but don't worry - it shouldn't affect your setup. We're looking at removing this check in the future as it's not as necessary as in the past. Thanks!

aboarken commented 4 years ago

@jamesmcq, Hello. Any updates regarding this notice? Still not removed from Office 365 Plugin.

jamesmcq commented 4 years ago

@ahmadm42 I am no longer the maintainer of this project. Please contact @weilai-irl

aboarken commented 4 years ago

@jamesmcq. Thanks and sorry for the inconvenience.

aboarken commented 4 years ago

@weilai-irl, FYI please. Thanks in advance.

nenorojas commented 4 years ago

Hi @ahmadm42 , we have reopened this case and will evaluate the efforts to add in a future release.

aboarken commented 4 years ago

@nenorojas , thanks in advance.

bbusschots-mu commented 4 years ago

I'm having this same issue on the latest Moodle 3.5 LTS and the latest version of this plugin for Moodle 3.5.

weilai-irl commented 4 years ago

Hi all,

A fix to the issue has been included in the latest release of the plugin suite for Moodle 3.7, 3.8 and 3.9 (release 3.7.0.7, 3.8.0.3, and 3.9.0 respectively). The root of the issue is the reply URL check was checking against an outdated version of server response, thus showing misleading warning messages. The check was updated now and would show no warning if the integration is configured correctly.

I'll close the issue now.

Regards, Lai

jtyms commented 3 years ago

Hi guys,

I have just updated to moodle 3.10+ and updated office365 integration (3.10) but it's giving me this error.

Thanks

o365_error

weilai-irl commented 3 years ago

@jtyms,

I can confirm this is a separate issue as the one originally supported. Please create a new one in the future, or if you have any question about my answer below.

The reason you saw this is because the stored application token in your database was created for a different scope, possibly the legacy Azure AD API, rather than the new Graph API. To fix this, please check the following:

This should remove any existing token, and create new ones.

Please give it a try. As I said, if this doesn't work, or if you have more questions, please create a new issue for it.

Regards, Lai

jtyms commented 3 years ago

@weilai-irl

Thank you, I did the steps you have mentioned and it's now working.

Regards,

J

ssg1developer commented 2 years ago

hi, i'm using moodle 3.11 and OpenID connect 3.7.0.1 for office 365 authentication for our moodle site. Suddenly there are problem when user sign in with their office 365 credential in our moodle site. When we check in "Microsoft Office 365 Integration" menu, the Azure AD Setup cannot be done.

we try using the same application ID and key in our development site and there is no issue.

image

weilai-irl commented 2 years ago

Hi @ssg1developer,

Please upgrade your auth_oidc plugin. 3.7.0.1 was from July 2019, and it has been out of support for very long time now. The latest release as of now is 3.11.4 can be downloaded at https://moodle.org/plugins/auth_oidc/3.11.4/26880 (auth_oidc)and https://moodle.org/plugins/local_o365/3.11.4/26886 (local_o365).

Regards, Lai

ssg1developer commented 2 years ago

Hi Lai, thanks for your respond. we already follow your suggestion to update auth_oidc and local_o365 to latest version and now our client can login using office 365 authentication on our site.

ssg1developer commented 7 months ago

Hi, currently i'm using moodle 3.11.4 and update the OpenID plugin and local_o365 to version 3.11.5, but when we try to verify setup, there is error message "There was an error checking legacy API settings.". Any suggestion for me to check ?