microsoft / o365-moodle

Office 365 and Azure Active Directory plugins for Moodle
GNU General Public License v3.0
184 stars 138 forks source link

moodle-block_microsoft on Moodle 4.01 breaks Moodle #2046

Closed sprezlaus closed 2 years ago

sprezlaus commented 2 years ago

We are testing Moodle 4.01 in a safe environment, upon installation of (block_microsoft_moodle311_2021051720.zip) via the "upload-plugin"-page of Moodle, the whole Moodle-installation went fubar and only displays error 500's.

Environment: VPS running freshly installed centos 7, no https enabled, no Selinux Context: we're mainly adjusting our theme to 4.0, but while at it, we try to install the plugins we had on 3.11. The VPS is expandable, acces could be given if needed.

weilai-irl commented 2 years ago

Hi @sprezlaus,

The plugins are not officially supporting Moodle 4.0 yet. We are still in the progress upgrading the plugins to Moodle 4.0, but so far we haven't seen anything like what you described.

Can you check your server access log for error details please. Does remove the plugin solve the issue? Did it happen when uploading other plugins in the suite (auth_oidc and local_o365 in particular)?

Regards, Lai

sprezlaus commented 2 years ago

Hi @weilai-irl

I get a 500 on /admin/index.php?cache=0&confirmplugincheck=0 after clicking "continue" on the validation page. Apache/httpd error_log doesn't mention anything. Access_log: 134.184.232.68 - - [10/May/2022:15:08:30 +0000] "POST /admin/tool/installaddon/index.php HTTP/1.1" 303 1613 134.184.232.68 - - [10/May/2022:15:08:30 +0000] "GET /admin/tool/installaddon/index.php?installzipcomponent=block_microsoft&installzipstorage=627a7feeec786&sesskey=8xp5bfzolL HTTP/1.1" 200$ 134.184.232.68 - - [10/May/2022:15:08:32 +0000] "POST /admin/tool/installaddon/index.php HTTP/1.1" 303 1533 134.184.232.68 - - [10/May/2022:15:08:32 +0000] "GET /admin/index.php?cache=0&confirmplugincheck=0 HTTP/1.1" 500 - 134.184.232.68 - - [10/May/2022:15:08:36 +0000] "GET /admin/index.php?cache=0&confirmplugincheck=0 HTTP/1.1" 500 - 134.184.232.68 - - [10/May/2022:15:09:48 +0000] "GET /admin/index.php HTTP/1.1" 500 - 134.184.232.68 - - [10/May/2022:15:09:49 +0000] "GET /admin/index.php HTTP/1.1" 500 - 134.184.232.68 - - [10/May/2022:15:10:21 +0000] "GET /admin/tool/installaddon/index.php HTTP/1.1" 200 189480 134.184.232.68 - - [10/May/2022:15:10:22 +0000] "GET /theme/cvosemper/pix/logo_cvosemper.svg HTTP/1.1" 304 - 134.184.232.68 - - [10/May/2022:15:10:23 +0000] "GET /admin/search.php HTTP/1.1" 303 1500 134.184.232.68 - - [10/May/2022:15:10:24 +0000] "GET /admin/index.php HTTP/1.1" 500 -

If you are familiar with Centos, I can give you access to reproduce the error (creds over twitter or mail?)

I know 4.x isn't supported yet, but it seems like something that might be of importance. Haven't tried with oidc or o365 yet.

Kind regards, Steven

weilai-irl commented 2 years ago

Hi @sprezlaus,

Could you try to install the plugin via other methods? e.g. upload unzipped files to DIRROOT/blocks/microsoft path directly? The error you are seeing is possibly to do with how the server processes the zip file, which is out of the control of the plugin itself.

Also, block_microsoft has a dependency on local_o365 which in turn has a dependency on auth_oidc. You will get an error (it's a different, much more user friendly one than the one you see) if trying to install block_microsoft alone without the other plugins.

Regards, Lai

weilai-irl commented 2 years ago

Hi @sprezlaus,

We have made a new release of the plugins which officially supports Moodle 4.0. The particular issue that you reported didn't come up in our test, and I'm confident that it was caused by your environment, rather than the plugin itself. I'll close the issue now.

Regards, Lai