microsoft / o365-moodle

Office 365 and Azure Active Directory plugins for Moodle
GNU General Public License v3.0
180 stars 137 forks source link

Error When Editing Quiz Settings #2248

Open lewisrobinsonsynergylearning opened 1 year ago

lewisrobinsonsynergylearning commented 1 year ago

Hi there,

hope all is well.

I just wanted to report a potential issue that can occur when editing a quiz. The issue seems to be similar to the one reported here https://github.com/microsoft/o365-moodle/issues/2092 and has occurred because deleted users have no record/token stored in auth_oidc_token. When the quiz event is updated an attempt is made to update the event in the deleted user's Outlook calendar but as the user has no token this error is thrown.

error output

The Moodle version this was encountered in is 3.11.11+ (Build: 20221118) and the plugin version is currently 2021051730.

Please let me know if I can provide anymore information.

Many kind regards,

Lewis Robinson, Synergy Learning

synergylearning-github commented 1 year ago

Good morning,

Has there been any progress on looking into this calendar sync issue, we have the same issue happening now for a different customer who has recently upgraded from 3.11 to 4.1. The local_o365 is up to date with the latest version available on the Moodle Plugins page, but they are seeing an error when they try to hide an activity on a course:

Exception - Argument 3 passed to local_o365\rest\unified::update_event() must be of the type string, null given, called in [dirroot]/local/o365/classes/feature/calsync/main.php on line 482 File: ...65/classes/rest/unified.php Line: 1343

Error code: generalexceptionmessage

I've noticed that 'MOODLE_401_STABLE' has an incremented version available here on GitHub but has not been updated on the Moodle Plugins page, can you confirm if this has been submitted to Moodle for review?

Screenshot 2023-09-14 at 12 00 35

Kind regards, David