search

microsoft / o365-moodle

Office 365 and Azure Active Directory plugins for Moodle
GNU General Public License v3.0
180 stars 136 forks source link

Apparent Regression — Upper-case UPNs Failing to match to Moodle Users #2357

Open bbusschots-mu opened 1 year ago

bbusschots-mu commented 1 year ago

Some years ago this plugin failed to match users if the Office365 UPN had upper case letters in it, because the comparison to the Moodle email/username field was failing because Moodle casts those to lower case.

This results in nonsense errors when the user tries to log in of the form:

The Microsoft 365 account BOB@DOMAIN.TLD is already matched with Moodle User bob@domain.tld. To complete connection please log in as that Moodle user first and follow the instructions in the Microsoft block.

The user is if course logging in as the account the error is telling them to, and there is no way past this error — the user is locked out of Moodle!

weilai-irl commented 8 months ago

Hi @bbusschots-mu

Could you check if this is still a problem please? I tested it again just now on the latest Moodle 4.1/4.2/4.3 releases of the plugin, but I didn't see any issue. Here are the steps that I followed:

  1. Create Microsoft account with UPN BOB@domain.ltd.
  2. Create Moodle account with username bob@domain.ltd and authentication method auth_oidc.
  3. Log in to Moodle using auth_oidc and username BOB@domain.ltd.

Are different steps required to recreate the issue?

Regards, Lai

bbusschots-mu commented 7 months ago

Hi @weilai-irl — I'be been on extended leave for nearly 2 months, so just getting caught up now.

We've not had any more reports of issues, and we are currently running OpenID Connect and Microsoft 365 Integration 4.1.3 (2022112815).