search

microsoft / o365-moodle

Office 365 and Azure Active Directory plugins for Moodle
GNU General Public License v3.0
182 stars 136 forks source link

Issue with Moodle 4.3 #2384

Closed nbozhkov-ucl closed 11 months ago

nbozhkov-ucl commented 1 year ago

We have been testing the upgrade from Moodle 4.2.2 to Moodle 4.3beta to spot early problems & get fixes before 4.3 official release. After we upgraded succefully, AAD authentication no longer works coming up with the below error message.

Exception - update_internal_user_password(): Argument #2 ($password) must be of type string, null given, called in [dirroot]/lib/moodlelib.php on line 4484

nbozhkov-ucl commented 1 year ago

Using versions: auth_oidc 2023042405 local_o365 2023042405

weilai-irl commented 1 year ago

Hi @nbozhkov-ucl

Thank you for reporting the issue. We haven't started testing the plugins on Moodle 4.3 yet since it hasn't been released. Official support for new Moodle versions are normally added within one month after the release. We have a full set of test cases to run so this may take some time. I'll add the issue reported to the list of items to fix for Moodle 4.3 release.

Regards, Lai

adminxpcom commented 1 year ago

In admin Page - new Moodle 4.3 (PHP Version 8.2.11):

Deprecated: Creation of dynamic property local_o365\adminsetting\tabs::$component is deprecated in /var/www/html/moo43/local/o365/classes/adminsetting/tabs.php on line 67

Deprecated: Creation of dynamic property local_o365\adminsetting\tabs::$theme is deprecated in /var/www/html/moo43/local/o365/classes/adminsetting/tabs.php on line 68

Deprecated: Creation of dynamic property block_microsoft::$globalconfig is deprecated in /var/www/html/moo43/blocks/microsoft/block_microsoft.php on line 43

Output buffer:
Deprecated: Creation of dynamic property auth_oidc\oidcclient::$scope is deprecated in /var/www/html/moo43/auth/oidc/classes/oidcclient.php on line 93

weilai-irl commented 11 months ago

@nbozhkov-ucl, @opitz

Thank you for reporting and issue and providing solution. The latest release of the plugins from today (v4.3.0, https://moodle.org/plugins/auth_oidc/4.3.0/30700) should fix this one. Please check it out.

Regards, Lai