microsoft / oauth2-useragent

Microsoft OAuth 2.0 User Agent library for Java. Provides classes to facilitate the implementation of "4.1. Authorization Code Grant" from RFC 6749.
Other
35 stars 22 forks source link

Ignore stderr when we call JavaFx provider first #11

Closed yacaovsnc closed 8 years ago

yacaovsnc commented 8 years ago

The stderr maybe benign, but in its presence our process fails. We should first try parse the stdout and if we could parse out a correct authorization code from the stdout, then treat the error more seriously. Otherwise even if there are stderr, but the code is retrieved, we should simply ignore it.

msftclas commented 8 years ago

Hi @yacaovsnc, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Yang Cao (VSNC)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

davidstaheli commented 8 years ago

Thanks, Yang.