search

microsoft / oauth2-useragent

Microsoft OAuth 2.0 User Agent library for Java. Provides classes to facilitate the implementation of "4.1. Authorization Code Grant" from RFC 6749.
Other
35 stars 22 forks source link

Friendly Provider determination #21

Closed olivierdagenais closed 8 years ago

olivierdagenais commented 8 years ago

Implements the spirit of issue #13, with slight deviations/improvements from the original plan.

The good news is the new methods are written based on fragments of the old methods, so I was able to preserve most of the existing functionality.

olivierdagenais commented 8 years ago

@yacaovsnc: Please validate in your downstream library as part of your code review.

olivierdagenais commented 8 years ago

I made the changes I was suggesting, such that a call to findCompatibleProvider will now have checked compatibility of the returned Provider implementation. Can you try this in your project?

yacaovsnc commented 8 years ago

Tested, works as advertised!