search

microsoft / oe-engine

ACC template generation engine
MIT License
11 stars 14 forks source link

Add logs to provision failing and disable remote_attestation test #39

Closed johnkord closed 5 years ago

johnkord commented 5 years ago

This addresses two newly opened issues regarding ACC deployments.

  1. This sets the bash "-x" flag to produce logs for both deployment and validate scripts. It stores the log messages in .log files in /opt/azure/acc
  2. This entirely removes the remote_attestation test from being run in the validate script. Previously, the validate script was running the remote_attestation test and supposedly ignoring errors from the "make run" command by using the bash logical OR construct "||" to avoid the "set -e" flag from causing the script to error. However, in practice, we noticed a deployment failure once when the remote_attestation test failed. Since we are supposed to ignore the error from the remote_attestation test in general, we might as well simply not even run the test.
johnkord commented 5 years ago

Tagging @anupaaggarwal to loop her in to these changes

soccerGB commented 5 years ago

LGTM