search

microsoft / oe-engine

ACC template generation engine
MIT License
11 stars 14 forks source link

Fix regression with the data disks implementation #47

Closed oprinmarius closed 5 years ago

oprinmarius commented 5 years ago

Currently, the data disks implementation doesn't work when used with the custom VHD scenario.

Upon investigation, we found out that the {{GetDataDisks .}} is not necessary in the parts/resources.t template, and removing it solves the regression.

Fixes https://github.com/microsoft/oe-engine/issues/46

achamayou commented 5 years ago

@oprinmarius does this mean that datadisks stop working?

oprinmarius commented 5 years ago

@achamayou this is a WIP in an attempt to fix https://github.com/microsoft/oe-engine/issues/46

oprinmarius commented 5 years ago

@achamayou https://github.com/microsoft/oe-engine/blob/76a5f380be5f582be209d32764f0a739bee8f2f1/parts/accbase.t#L18-L21 The following error occurs: resources.t:52:25: executing "resources.t" at <.>: wrong type for value; expected *api.VMProfile; got *api.Properties .

The datadisk parameter is still included in the template parts/vmvars.t , whose value is in turn being used https://github.com/microsoft/oe-engine/blob/76a5f380be5f582be209d32764f0a739bee8f2f1/parts/vmresources.t#L85

ionutbalutoiu commented 5 years ago

@oprinmarius does this mean that datadisks stop working?

Hello achamayou!

The current PR fixes the regression https://github.com/microsoft/oe-engine/issues/46. Updated the PR title and description accordingly to have clear information on why we're doing this change.

Regards, Ionut